nnpdf icon indicating copy to clipboard operation
nnpdf copied to clipboard

use the agnostic "data" covmat instead of "t0" or "experimental" covmat to avoid confusion

Open RoyStegeman opened this issue 4 years ago • 3 comments

Currently in the code the t0 covmat is sometimes also called "experimental covmat", while the published papers clearly distinguish t0 covmats from experimental covmats. In some places this is a result of the fact that the covmat is delivered through vp while the code that uses the covmat might be agnostic to the exact definition.

The proposed solution is to replace the names in the code and docstrings with "data" covmats, which can refer to either experimental or t0 covmat (or any other possible covmat in the future).

RoyStegeman avatar Jan 12 '22 15:01 RoyStegeman

Makes sense to me.

Zaharid avatar Jan 13 '22 10:01 Zaharid

Did we ever do this? Do we want to do it?

scarlehoff avatar Dec 07 '22 09:12 scarlehoff

No we never did, and I would no longer want to do it this way. Instead we should just use t0 and exp correctly (which I think may not be the case now for the docs)

RoyStegeman avatar Dec 07 '22 09:12 RoyStegeman