NLog.Web icon indicating copy to clipboard operation
NLog.Web copied to clipboard

Added readme to ASP.NET Core package on nuget.org

Open 304NotModified opened this issue 4 years ago • 6 comments

See Package readme on NuGet.org docs and MSBuild docs

  • [ ] enable snupgk. But currently leads to NU5039 -> 2021-07-24 not fixed yet
  • [x] wait for dotnet RTM - undo image: Visual Studio 2019 Preview
  • [ ] update/split readme for ASP.NET and ASP.NET Core (readme is currently tweaked for ASP.NET Core only)

304NotModified avatar May 03 '21 21:05 304NotModified

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar May 03 '21 22:05 sonarqubecloud[bot]

preview: https://www.nuget.org/packages/NLog.Web.AspNetCore/4.13.0-readme-preview

image

304NotModified avatar May 03 '21 22:05 304NotModified

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 24 '21 22:07 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Apr 21 '22 20:04 sonarqubecloud[bot]

Flaky test (tests current date time with minutes)

304NotModified avatar Apr 21 '22 20:04 304NotModified

Codecov Report

Merging #662 (2ac7ecd) into master (71de77e) will increase coverage by 0%. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #662   +/-   ##
=====================================
  Coverage      63%    64%           
=====================================
  Files          48     48           
  Lines         790    827   +37     
  Branches      195    213   +18     
=====================================
+ Hits          500    527   +27     
- Misses        220    230   +10     
  Partials       70     70           
Impacted Files Coverage Δ
...tRenderers/AspNetRequestRouteParametersRenderer.cs 13% <0%> (-7%) :arrow_down:
...outRenderers/AspNetRequestHeadersLayoutRenderer.cs 86% <0%> (+5%) :arrow_up:
...enderers/AspNetRequestQueryStringLayoutRenderer.cs 91% <0%> (+10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71de77e...2ac7ecd. Read the comment docs.

codecov-commenter avatar May 16 '22 20:05 codecov-commenter

Can this be closed now that we have the PR https://github.com/NLog/NLog.Web/pull/898?

bakgerman avatar Dec 28 '22 04:12 bakgerman

Yes it does. Thanks!

304NotModified avatar Dec 28 '22 18:12 304NotModified