PiZilla icon indicating copy to clipboard operation
PiZilla copied to clipboard

index is proxyed and /dev-server added to output.publicPath

Open ghost opened this issue 8 years ago • 6 comments

Index is proxyed to localhost:8000 output.publicPath is set to /dev-server

ghost avatar Dec 03 '17 09:12 ghost

@scarecrow21, the commit structure is too verbose. Simplify it a bit.

Follow this structure:

Shorlog: Basic Description

Detailed Description for the Commit

Fixes <issue_url>

naveenkumarsangi avatar Dec 03 '17 10:12 naveenkumarsangi

git commit -m "shortlog , detailed description, fixes<issue_url>" Do you want it to be like this?

I'm new to open source.

ghost avatar Dec 03 '17 13:12 ghost

No, no, it's different. Try git commit --amend, you'll be presented with an in terminal editor (vim or nano based on your configuration). You can then use it to edit the commit message.

For more details please visit http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html.

naveenkumarsangi avatar Dec 03 '17 15:12 naveenkumarsangi

@scarecrow21, Since this is your first contribution to PiZilla, I'm exempting you from the commit message restrictions. But please follow then from the next time.

naveenkumarsangi avatar Dec 04 '17 11:12 naveenkumarsangi

You'd also need to change the line https://github.com/NITDgpOS/PiZilla/blob/master/server/routes.js#L35 to '/dev-server' + webpackConfig.output.filename for the second parameter to the url.resolve function.

This will let the client work in development mode.

naveenkumarsangi avatar Dec 04 '17 11:12 naveenkumarsangi

Sorry. Will commit according to the guidelines next time.

ghost avatar Dec 04 '17 14:12 ghost