PiZilla icon indicating copy to clipboard operation
PiZilla copied to clipboard

added openPage in webpack.config.babel.js

Open ghost opened this issue 8 years ago • 6 comments

It doesn't seem to work. What am I doing wrong?

ghost avatar Dec 02 '17 06:12 ghost

And please follow the commit log structure as shown below.

Shortlog: Description of the Commit

Detailed description, if required.

Fixes < full url to the issue e.g.: Fixes https://github.com/nitdgpos/issues/1 >

if your commit fixes some issue, then note in the

naveenkumarsangi avatar Dec 02 '17 09:12 naveenkumarsangi

Yes. Didn't see the comments. Will do.

ghost avatar Dec 02 '17 10:12 ghost

And please never merge master branch into your branches. Keep the commit history linear by rebasing stuff.

naveenkumarsangi avatar Dec 03 '17 05:12 naveenkumarsangi

And I don't see the need for 6 commits here. We can just do it in two, since it's a minor change.

naveenkumarsangi avatar Dec 03 '17 05:12 naveenkumarsangi

Also, please use eslint before you push any changes. We follow some coding guidelines here.

naveenkumarsangi avatar Dec 03 '17 05:12 naveenkumarsangi

I made a new PR. Tell me if any changes.

ghost avatar Dec 03 '17 09:12 ghost