Fearch icon indicating copy to clipboard operation
Fearch copied to clipboard
verified publisher icon NITDgpOS

#124 Implement Search history

Open phoenix7139 opened this issue 6 years ago • 3 comments

  • popup.js: Store the query searched by the user and corresponding URL to localStorage.
  • options.js: Retrieve stored query and URL from localStorage and display.
  • options.html, options.css: revamp the UI - add back button, history page and clear history button.

phoenix7139 avatar Feb 11 '19 09:02 phoenix7139

image1

User entering query into search bar

image2

query gets stored and displayed under history

phoenix7139 avatar Feb 11 '19 09:02 phoenix7139

@phoenix7139 Great work with the PR and idea of feature. We will be going over few iterations and will make your PR ready to be added to the codebase. I have added few suggestions if you can incorporate them it will be really awesome.

PaliwalSparsh avatar Feb 11 '19 17:02 PaliwalSparsh

Is it okay to disable just a few eslint rules such as vars-on-top, no-redeclare and no-unused-vars?

phoenix7139 avatar Mar 02 '19 09:03 phoenix7139