tracing-stackdriver icon indicating copy to clipboard operation
tracing-stackdriver copied to clipboard

Compile-time enforce to the right OTEL version

Open thomaseizinger opened this issue 1 year ago • 2 comments

It would be nice if we could change the API to be forced to pass a type from the otel-sdk crate somewhere to ensure we get a compile-error when there is a version mismatch.

Currently, things will just silently break if you bump one version but not the other :(

thomaseizinger avatar Mar 07 '24 20:03 thomaseizinger

This silent failure caused us to have issues for a while. We've been trying to figure out a way to enforce this at compile time (or allow the user to pass in a specific OtelData TypeId, but it's difficult without tracing-subscriber changes. Curious to hear if you resolved in another way (we just bumped version on our fork).

0xcypher02 avatar Sep 18 '24 15:09 0xcypher02

This silent failure caused us to have issues for a while. We've been trying to figure out a way to enforce this at compile time (or allow the user to pass in a specific OtelData TypeId, but it's difficult without tracing-subscriber changes. Curious to hear if you resolved in another way (we just bumped version on our fork).

I played around with this for a while but also couldn't get anything meaningful to work. So far, I've enforced it manually in the dependency bumps.

thomaseizinger avatar Sep 19 '24 00:09 thomaseizinger