validate icon indicating copy to clipboard operation
validate copied to clipboard

As a user, I want to validate multiple bundles at once

Open rchenatjpl opened this issue 5 years ago • 2 comments

The attached has multiple bundle.xml and collection.xml files. A single validate of the entire directory (I may be the only person to validate more than 1 bundle at a time) incorrectly throws errors because collection_ancillary/ is duplicated in every bundle, which is legal because it is primary in only one bundle and secondary in the other 7. Including a copy of a secondary collection is explicitly mentioned in the footnote on page 10 of the Sep 2017 PDS4 Standards Reference.

Hmm, what will validate do if the LID of a secondary product (not collection) shows up twice in the same bundle? I've never noticed this happening before, and I can't think of a good scenario. Maybe a calibration file from a different bundle is listed in both document/collection.csv and data_calibration/collection.csv.

Workaround

See some possible workarounds for this on our discussion board: https://github.com/NASA-PDS/validate/discussions/796

rchenatjpl avatar Jun 17 '20 07:06 rchenatjpl

secondary.zip

rchenatjpl avatar Jun 17 '20 07:06 rchenatjpl

@rchenatjpl I'm not positive, but I believe there is a general assumption in validate that you are running the software against a maximum of 1 bundle. throughout the software, there are many places where we check duplicates and counters and don't keep in memory the idea of multiple bundles. we can probably build this in, but I'm not sure this will be a high priority considering I'm not sure people validate.

also, yikes. multiple bundles for the same instrument seems kind of counter-intuitive to normal bundle/collection design, but I guess that is what we get with PDS3 migration :-)

jordanpadams avatar Jun 17 '20 14:06 jordanpadams