common-workflow-service icon indicating copy to clipboard operation
common-workflow-service copied to clipboard

Issues with elasticsearch_host changes

Open Gillingham opened this issue 4 years ago • 2 comments

  1. elasticsearch_host seems to now require a protocol prefix, but this change isnt documented anywhere, the sample props still have elasticsearch_host=[YourElasticsearchHost]
  2. #80 Doesn't actually catch the missing prefix as the check happens after the curl call. If the prefix is missing the curl call will fail and return before the check for the prefix happens.
  3. Since it's no longer just the host, the variable itself should get renamed, maybe .._host and ..._port should both go away and be replaced with elasticsearch_url or something along those lines.

For future consideration, how should breaking changes like this be announced/documented? I was surprised when trying out the beta build that our install now fails, but I had to dig through github issues and commits/source code to find out why, not an ideal process. Maybe this project needs a public CHANGELOG ala Keep a Changelog in repo.

Gillingham avatar Feb 09 '22 22:02 Gillingham

Hi @Gillingham , i'll be updating the Wiki https://wiki.jpl.nasa.gov/display/cws/CWS+Platform+Prerequisites before CWSv2.2 release with the new config details and features. It should be up by this coming Monday.

And I agree with the including a CHANGELOG in the repo. I've made a branch for that and it'll have the notable additions and changes from the current version of the repo

-Josh

voxparcxls avatar Feb 10 '22 19:02 voxparcxls

Update: https://github.com/NASA-AMMOS/common-workflow-service/pull/97

voxparcxls avatar Jun 29 '22 00:06 voxparcxls