AIT-DSN
AIT-DSN copied to clipboard
Deframer / Packet Processor Follow-on
Follow on to issues raised on #127
- General notes
Can you look into adding a more thorough example of execution? For instance, something on the order of:
Boot up packet processor
Execute example script which dumps frames to the input port. These frames would contain some CCSDS packets for one of our default Core Telemetry packet definitions.
This would give us something small to run as a demo with data viewable in the GUI. Something like marching integers would be more than adequate.
- Update Documentation ToC with link to
deframer_packet_processor.rstso it's easier to find - Bin script for the tool should be defined in the normal
bindirectory so it is properly linked on package install. https://github.com/NASA-AMMOS/AIT-DSN/blob/master/ait/dsn/proc/deframe_packet_processor.py#L1153 - There's a few places where configuration values or class names are referenced. For the class names please update so they reference the various classes with :class: so the code will link to stuff. For config names can we bold them? I think that's what we do in other docs (especially Core) to help with legibility.
- Can we please add a section outlining all of the config values and explaining in detail what changing them does?