sui icon indicating copy to clipboard operation
sui copied to clipboard

Use SuiClient instead of RPCGatewayClient in Sui CLI

Open patrickkuo opened this issue 3 years ago • 3 comments

Changes

  • Replaced RPCGatewayClient with SuiClient
  • Cleaned up Sui-gateway dependencies
  • Use SuiClient in Sui CLI, preparing it to support querying full nodes.
  • Enhance Sui SDK apis to make it more rust friendly
    • Use TransactionData and Transaction instead of TransactionBytes and raw Base64 encoded bytes.
    • Added method in SuiKeystore to return Signer for transaction signing

TODOs

  • add commands to support querying full node in Sui CLI
  • SuiClient should check for the RPC server's available modules and handle it gracefully (and better error msg) when user invoke an unsupported method.

patrickkuo avatar Jul 21 '22 12:07 patrickkuo

hi @lxfind @longbowlu @joyqvq can I get a thumbs up from you guys :)

patrickkuo avatar Jul 25 '22 21:07 patrickkuo

Hi Patrick,

Is this something we should announce? Any changes needed to the Sui CLI client docs? Thanks!

Clay-Mysten avatar Jul 25 '22 21:07 Clay-Mysten

Hi Patrick,

Is this something we should announce? Any changes needed to the Sui CLI client docs? Thanks!

All the doc changes are covered in this PR, we still haven't publicly announced the Rust SDK, I will sync with Janet.

patrickkuo avatar Jul 26 '22 14:07 patrickkuo