sui icon indicating copy to clipboard operation
sui copied to clipboard
verified publisher icon MystenLabs

[move]Use some Move 2024 Syntax to update 'utils' example

Open shaflow01 opened this issue 1 year ago • 7 comments

Description

Use some Move 2024 Syntax to update 'utils' example.

Test plan

test2

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • [ ] Protocol:
  • [ ] Nodes (Validators and Full nodes):
  • [ ] Indexer:
  • [ ] JSON-RPC:
  • [ ] GraphQL:
  • [ ] CLI:
  • [ ] Rust SDK:

shaflow01 avatar May 04 '24 15:05 shaflow01

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 0:16am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:16am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:16am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:16am

vercel[bot] avatar May 04 '24 15:05 vercel[bot]

@amnn Waitting for your review

shaflow01 avatar May 07 '24 07:05 shaflow01

Hi @shaflow01, the best way to get PRs such as this reviewed quickly is to add the "devx-move" team as a reviewer!

I will try and take a look today.

amnn avatar May 07 '24 07:05 amnn

Hi @shaflow01, the best way to get PRs such as this reviewed quickly is to add the "devx-move" team as a reviewer!

I will try and take a look today.

how to add it? Is there any instruction added when submitting a push request？

shaflow01 avatar May 07 '24 08:05 shaflow01

Could you teach me in detail? I would like to try it out

shaflow01 avatar May 07 '24 08:05 shaflow01

When submitting a PR, you can select the "Reviewers" on the right:

Screenshot 2024-05-07 at 12 14 41 PM

Search for "devx-move" there and select the option that shows up!

amnn avatar May 07 '24 11:05 amnn

When submitting a PR, you can select the "Reviewers" on the right:

Screenshot 2024-05-07 at 12 14 41 PM Search for "devx-move" there and select the option that shows up!
63dc2187557d26657868d95f812ab67 I don't seem to have this button.This is what troubles me

shaflow01 avatar May 07 '24 11:05 shaflow01

When submitting a PR, you can select the "Reviewers" on the right: don't seem to have this button.This is what troubles me

Ah yes, it seems it's disabled for non Mysten Labs users. We have a system in place to notify us, and we'll triage the PRs and assign the right reviewers. Keep'em coming and thanks for your contribution!

stefan-mysten avatar May 08 '24 04:05 stefan-mysten

Thank you very much for the answers from amnn and Stefan Mysten. I understand now

shaflow01 avatar May 08 '24 08:05 shaflow01