adapt Add "excludes" to Intent

Excluding one or more entities will cause a match to fail if any of those entities are present.

Mar 08 '22 15:03 synesthesiam

Hope this one isn't forgotten, still looking forward for it :)

Nov 03 '22 00:11 JarbasAl

fingers crossed this one was closed accidentally :crossed_fingers:

Feb 04 '23 19:02 JarbasAl

I haven't had the time to get this over the finish line 🫤

Feb 05 '23 00:02 synesthesiam

@JarbasAl @goldyfruit Can you link some examples of this being used to confirm things function as expected? I don't see any unit test coverage so I'd like to see some examples of how its working

Apr 12 '24 15:04 NeonDaniel

@JarbasAl @goldyfruit Can you link some examples of this being used to confirm things function as expected? I don't see any unit test coverage so I'd like to see some examples of how its working

Some tests coverage are already in the PR :1st_place_medal:

Apr 12 '24 16:04 goldyfruit

Thanks @NeonDaniel :+1:

Apr 12 '24 16:04 goldyfruit

Looking at the automation, this may also need a version bump in the PR.. I also see tests should have been triggered on PR so I'm not sure why that didn't happen

Apr 12 '24 16:04 NeonDaniel

Some tests coverage are already in the PR 🥇

Excited to see this getting some traction again! While the test added provides coverage for the full integration of excludes into IntentEngine, I was also hoping to seem something more targeted that flexes Intent.validate with exclusions, similar to what we see in IntentTest.

I think I've reasoned my way around how this will interact in a system with many intents (it should be relatively isolated to itself, though with the expected vocabulary comingling).

Also, +1 to @NeonDaniel 's note that we need a version bump here.

Apr 17 '24 02:04 clusterfudge