myrobotlab icon indicating copy to clipboard operation
myrobotlab copied to clipboard

Clean up open source license headers in source files.

Open kwatters opened this issue 7 years ago • 3 comments

clean up to make sure all apache 2.0 license headers are proper and consistent across all mrl source files. identify any license conficts.

kwatters avatar Nov 13 '18 17:11 kwatters

My software engineering professor even had the controversial opinion that there should be no license header etc. in each source file. Only once in the project root and for exceptions. I don't care about which option is choosen, just this being consistent would be nice : )

LunDev avatar Nov 14 '18 18:11 LunDev

I like the idea to put license Inside each files, if someone grab,only few functionalities from the project. As in a cooked dish I would like to know where the meat comes from and the vegetables :)

moz4r avatar Nov 21 '18 13:11 moz4r

We currently have the LICENSE file at the root. I vote we remove all license files from source code that is not currently Apache 2.0. If some file is non-apache 2.0 we can leave the license in place unless we're changing the license that it's under.

kwatters avatar Jan 03 '19 21:01 kwatters

License information should not be in source files, a single one in the root of the project is sufficient. Additionally, the root of resource/{serviceNameType} we could put licenses for each service depending on dependencies. It's very well structured for this.

supertick avatar Apr 03 '23 14:04 supertick