PHP-CSS-Parser Parse simple expressions

Fixes #388 Builds on top of #390

Sep 19 '22 09:09 raxbg

For what it's worth, I'm including this patch in https://github.com/ampproject/amp-wp/pull/7487 and it is passing all tests in our project.

Mar 15 '23 23:03 westonruter

@oliverklee was this closed as well as other PRs (e.g. #185 and #193) just because the master branch was deleted?

Feb 07 '24 18:02 westonruter

@westonruter Oh no! It indeed was. ;-(

Feb 07 '24 18:02 oliverklee

I have now reinstated the legacy master branch and will reopen the PRs in a minute. So sorry for this.

Feb 07 '24 18:02 oliverklee

I have now reinstated the legacy master branch and will reopen the PRs in a minute. So sorry for this.

I would prefer we delete the master branch and just change all the PRs to point to main instead.

Feb 07 '24 20:02 sabberworm

@sabberworm Oh, I wasn't aware that this was possible in the first place! Will do.

Feb 07 '24 21:02 oliverklee

I have now moved all PRs over to main and dropped the master branch again.

Feb 07 '24 22:02 oliverklee

I like this. I'd be happy for this to be merged. @oliverklee, @sabberworm WDYT?

On further looking, a class-specific unit test is also needed for the new class (inherited from the terribly misnomered TestCase - Rename That!).

Feb 15 '24 03:02 JakeQZ

Also, according to the original commit message, this builds on on top of #390. So we should get that in first and then rebase.

Feb 15 '24 09:02 oliverklee

#390 is closed now and seems like it's no longer needed. There shouldn't be anything else blocking the merge of this PR :)

Let me know if you have any concerns

Jul 10 '24 12:07 raxbg