mycrypto.com icon indicating copy to clipboard operation
mycrypto.com copied to clipboard
verified publisher icon MyCryptoHQ

Etherscan api key in public

Open ETHAdminCORP opened this issue 7 years ago • 0 comments

Hello, MyCrypto Team! You didn't hide etherscan api key https://github.com/MyCryptoHQ/mycrypto.com/blob/feb64caf6331a4418c4cd2846b5b49574d31334b/app/scripts/nodeHelpers/etherscan.js#L113

Someone could make many requests to etherscan with this api key, and it will be blocked

We (https://ethadmin.com) prefer put such api keys in conf.json and don't keep it in github. And we've added conf.json to .gitignore

ETHAdminCORP avatar Dec 10 '18 21:12 ETHAdminCORP