MustardSimplify icon indicating copy to clipboard operation
MustardSimplify copied to clipboard

UI fixes and improvements

Open cl3m3c7 opened this issue 1 year ago • 7 comments

cl3m3c7 avatar Jun 28 '24 01:06 cl3m3c7

Thanks! I'll test those and approve this :)

Mustard2 avatar Jun 28 '24 11:06 Mustard2

and another thing, if you check simplify objects without checking modifiers (global options), an exception is being thrown, this line here is confusing to me! if objects requires modifiers to be enabled, then I think a little change in the poll function of MUSTARDSIMPLIFY_OT_SimplifyScene class might be needed, something like:

diff --git a/simplify/ops_simplify.py b/simplify/ops_simplify.py
index 7b052e0..557ec76 100644
--- a/simplify/ops_simplify.py
+++ b/simplify/ops_simplify.py
@@ -19,6 +19,8 @@ class MUSTARDSIMPLIFY_OT_SimplifyScene(bpy.types.Operator):
         settings = scene.MustardSimplify_Settings
 
         if not settings.simplify_status:
+            if settings.objects:
+                return settings.objects and settings.modifiers
             return settings.blender_simplify or settings.modifiers or settings.shape_keys or settings.physics or settings.drivers or settings.normals_auto_smooth
         else:
             return True

cl3m3c7 avatar Jun 28 '24 15:06 cl3m3c7

I guess you're right, if you want change also this :)

Mustard2 avatar Jun 28 '24 16:06 Mustard2

Waiting for the button thing, let's see if there's a way :)

Mustard2 avatar Jul 07 '24 00:07 Mustard2

I think this should be pushed as the last bug fix release for the 4.1 channel! there is a new method added in 4.2, but I am not able to get the desired result, here it is if you want to play with it! https://projects.blender.org/blender/blender/pulls/124139

cl3m3c7 avatar Jul 15 '24 14:07 cl3m3c7

also https://github.com/Mustard2/MustardSimplify/blob/d32be68f497fa664ec10f4507ac88f342be53bb4/simplify/ops_settings_blender_simplify.py#L40 and https://github.com/Mustard2/MustardSimplify/blob/d32be68f497fa664ec10f4507ac88f342be53bb4/simplify/ops_settings_blender_simplify.py#L57 blocks should be remove in the next release for 4.2. Read more

cl3m3c7 avatar Jul 15 '24 14:07 cl3m3c7

Ah nice, I'll remove those then

Mustard2 avatar Aug 05 '24 18:08 Mustard2

Need to rebase this on the new version and merge. I'll do it asap

Mustard2 avatar Jan 12 '25 22:01 Mustard2