Gittyup icon indicating copy to clipboard operation
Gittyup copied to clipboard

Make CommitList display "Working tree clean"

Open jensenr30 opened this issue 1 year ago • 5 comments

When there are no changes in the working directory, the top placeholder commit says "Working tree clean".

I added a function bool is_working_tree_clean(void) const in class CommitModel : public QAbstractListModel. Is there a better place to put this function? I'm a C++ beginner. I was trying to figure out how to access the is_working_tree_clean() function in other places in CommitList.cpp but couldn't figure out a clean way to do it...

image

Resolves #704

jensenr30 avatar Mar 05 '24 06:03 jensenr30

Thanks for the changes. Is this ready? I think the is_working_tree_clean function is fine there

Murmele avatar Mar 15 '24 16:03 Murmele

@Murmele I think this is good to merge in, but it might be nice to merge #714 first, because that fixes a bug with this element. But it's your call of course.

jensenr30 avatar Mar 16 '24 02:03 jensenr30

@Murmele I will leave this as a Draft until #714 gets merged in because this depends on #714.

jensenr30 avatar Apr 04 '24 04:04 jensenr30

Now this can be rebased as well :)

Murmele avatar May 22 '24 08:05 Murmele

Hmmm... Looks like I broke some tests... I'll look into this...

jensenr30 avatar May 22 '24 08:05 jensenr30