Gittyup icon indicating copy to clipboard operation
Gittyup copied to clipboard

[Bug] [UX] Change list scrolls to top when discarding & scrolls horizontally when cursor hovers scrollbar

Open KaKi87 opened this issue 2 years ago • 2 comments

Hello,

Here are 2 UX problems related to the change list.

It scrolls to top when discarding changes

Example case : there are 3+ changes, the first one is to be committed, the second one is to be discarded.

Reproduction steps :

  1. Mark the first change to be committed ;
  2. Scroll down to the second change ;
  3. Discard it.

Expected behavior :

  • the scroll position is preserved after the second change is discarded ;
  • the third change takes the second's place, allowing it to processed without further scrolling.

Actual behavior :

  • the scroll position is reset to the very top after the second change is discarded ;
  • the user must scroll down through the first change again to continue processing the following ones.

It scrolls horizontally when cursor hovers scrollbar

Example case : there are 2+ changes, the first one has horizontal scroll width.

Reproduction steps :

  1. Position the cursor anywhere in the change list view ;
  2. Scroll down ;
  3. The cursor eventually hovers the first change's horizontal scrollbar ;
  4. Continue scrolling.

Expected behavior : the change list continues to be scrolled down.

Actual behavior : the first change begins scrolling right.


Thanks

KaKi87 avatar Apr 13 '23 21:04 KaKi87

Addressing item number 2 (horizontal scroll UX issue):

@Murmele

What do you think about implementing something like a single scroll bar at the bottom of the diff window that would simultaneously scroll all the diffs of each file in sync? I have no clue how much work it would be to do this.

Concept:

image

jensenr30 avatar Feb 26 '24 04:02 jensenr30

Addressing item number 2 (horizontal scroll UX issue):

@Murmele

What do you think about implementing something like a single scroll bar at the bottom of the diff window that would simultaneously scroll all the diffs of each file in sync? I have no clue how much work it would be to do this.

Concept:

image

Yes this is something really anoying, but I think it is more work. As far as I remember then you have to dig into scintilla

Murmele avatar Feb 26 '24 06:02 Murmele