Multiverse
Name change profile migration not working correctly
It seems that when a player changes their name their inventories data is not being properly migrated. In addition to making this work, some improvements would be needed. We need to create a migrated profile directory to store backups of profiles that get migrated. That way in case anything goes wrong we can manually restore data from the backups.
I assume this is due to storing inventories in
worlds/{WORLD}/{PLAYER_NAME}.json
instead of
worlds/{WORLD}/{PLAYER_UUID}.json
even though the mapping exists in
players/{PLAYER_UUID}.json
Migration would be unnecessary if inventory data were stored by UUID and then mapped back to the player name.
Still a bug. Just caught it on my server. Went to find old players files, and are gone due to it knowing to switch to the UUID but the name didnt carry the files over...I'm guessing?
I think it's safe to say that everyone does. Note that there is a PR pending.
There is a test build here if you want to try https://github.com/Multiverse/Multiverse-Inventories/pull/362#issuecomment-648521734
This PR #428 should have elevated most of the migration issue, do update to the latest test build to try. Appreciate anyone that happens to change their player name to report how it went.
Just had an issue with this, luckily I was able to restore their inventory from a backup, but does anyone have a solution to this?
@untuned what version of MV Inventories were you using? This should be fixed as of 4.2.3, but if not, I had another unmerged change that could help.
@untuned what version of MV Inventories were you using? This should be fixed as of 4.2.3, but if not, I had another unmerged change that could help.
[21:09:35 INFO]: Multiverse-Inventories version 4.2.4-SNAPSHOT-b524
[21:09:35 INFO]: Author: dumptruckman
im using the last released version Multiverse-Inventories_4.2.6 i saw players inventories are saved with their name.. and or ith theire uuids?..
its confusing.. me
Here you see its stored by name..
and here by uuid...?
so if i change the name... does it convert this or renmae the files? or does it snyc with the players information stored in uuid?
its confusing me a bit..
what might i can asume what will happen... player changes his name. and logs in world a he has his inventory and all fine.. now he change to world b that has a seperate inventory...
because of the namechange the plugin might not see this other inventory anymore because it was made for the old name?
or does it rename all playername files from all worlds when player logs in? would be a fair deal, even if direct uuid support would be better...
im using the last released version Multiverse-Inventories_4.2.6 i saw players inventories are saved with their name.. and or ith theire uuids?..
its confusing.. me
Here you see its stored by name..
and here by uuid...?
so if i change the name... does it convert this or renmae the files? or does it snyc with the players information stored in uuid?
its confusing me a bit..
what might i can asume what will happen... player changes his name. and logs in world a he has his inventory and all fine.. now he change to world b that has a seperate inventory...
because of the namechange the plugin might not see this other inventory anymore because it was made for the old name?
or does it rename all playername files from all worlds when player logs in? would be a fair deal, even if direct uuid support would be better...
name changing wipes your inventory :/
