Multiverse-Core icon indicating copy to clipboard operation
Multiverse-Core copied to clipboard

Deprecated EntityCreatePortalEvent

Open SlimeDog opened this issue 6 years ago • 36 comments

Spigot 1.14.2 (Jenkins 2323) git-Spigot-03bd4b0-342194e (MC: 1.14.1) (Implementing API version 1.14.1-R0.1-SNAPSHOT) WorldGuard 7.0.0-SNAPSHOT;1889-2b854f0 Multiverse-Core 3.0.0-SNAPSHOT-b761

On server start-up:

[07:34:59] [Server thread/WARN]: [Multiverse-Core] "Multiverse-Core v3.0.0-SNAPSHOT-b761" has registered a listener for org.bukkit.event.entity.EntityCreatePortalEvent on method "public void com.onarandombox.MultiverseCore.listeners.MVPortalListener.entityPortalCreate(org.bukkit.event.entity.EntityCreatePortalEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [Rigby, fernferret, lithium3141, main--, dumptruckman].

SlimeDog avatar May 21 '19 14:05 SlimeDog

Yep, having this too.

ThybeVB avatar May 21 '19 22:05 ThybeVB

same

0xC1A551C avatar May 23 '19 17:05 0xC1A551C

It's universal. No reason to keep adding "me too". :)

SlimeDog avatar May 23 '19 23:05 SlimeDog

Minecraft 1.14.2 and Multiverse-Core v4.0.0-SNAPSHOT-b764: Tried the latest available Multiverse build: here is the full text from the Paper Server startup... (Posted as reference to others looking to post this issue, not to bug the developers) NOTE: This doesn't appear to bother server operation at this time other than any performance loss. I can't speak to that as I am new to the paper server and have no reference. Multiverse-Core v4.0.0-SNAPSHOT-b764" has registered a listener for org.bukkit.event.entity.EntityCreatePortalEvent on method "public void com.onarandombox.MultiverseCore.listeners.MVPortalListener.entityPortalCreate(org.bukkit.event.entity.EntityCreatePortalEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [Rigby, fernferret, lithium3141, main--, dumptruckman]

Meledosia avatar Jun 09 '19 13:06 Meledosia

I noticed I forgot to inform anyone viewing this that Multiverse is aware of the deprecated event that you're informed about in console. The "performance impact" isn't noticeable and is fine to ignore.

Jadiction avatar Jul 08 '19 17:07 Jadiction

Since this seems to be a known thing I guess I don't have to mention that I have this too?

Andre601 avatar Aug 21 '19 21:08 Andre601

Nope. You didn't have to mention it. :)

SlimeDog avatar Aug 21 '19 23:08 SlimeDog

And yet this issue is closed while not being addressed at all. Has to make one wonder what else might be in the project that isn't so obvious. This is very shoddy methodology. Makes one wonder if these guys are part of the "elite" that loves to tell beginners they know the answer but refuse to spoon feed. I've always felt the real reason for this attitude and a lack of a fix in cases like this are both due to having no clue what to do and an inability to admit it? No decent programmer would ignore their users and leave known errors for more than 3 months that reflect badly on the author's abilities if they could actually do something about the problem. Lame and pitiful.

Meledosia avatar Aug 22 '19 09:08 Meledosia

@GCD56 First of all, this issue is not closed. Secondly, we've acknowledged the "issue" on many occasions. Look at all the duplicate tickets we have closed linking to this one. Jadiction has even responded to this ticket explaining that we're aware of the "issue" and that it is something you can completely ignore as the performance impact is negligible/nonexistent.

The "issue" has not been fixed yet because the Spigot team removed a vital API from Bukkit in 1.14 yet they have stated they intend to add it back. Because of the removal of this API, We've had to build MV against 1.13 and create a hack to make the nether portal functionality work in 1.14. If we build against 1.14, we will lose support for 1.13. The only way to remove this warning is to build against 1.14 and use a new event to replace the deprecated event. Unfortunately, this new event does not exist in 1.13.

So, we're aware of the issue, we're aware of how to fix it, and we're also aware that there's no harm in not fixing it (besides having to deal with a ridiculous amount of people complaining about it.) Therefore, we are waiting for the Bukkit API situation to improve (and also the 1.14 performance issues to be fixed) so we can feel comfortable dropping support for 1.13.

p.s.

I am the sole developer on this project and I work on it and provide support for it for free*. I do not play MC anymore so I think you should be happy MV is even still being maintained in the slightest. I am a father, I work a full time job, and I like to have time to do things I enjoy when I can. I often do not have time to look at every single issue ticket that comes in (and there's a lot of them). However, I am often very responsive on Discord and I encourage anyone to come hang out in the MV discord and chat.

* I have recently started a Patreon page so people can help support my efforts on this project. However, even then I'm planning to use those funds to afford stuff for the MV project.

dumptruckman avatar Aug 22 '19 18:08 dumptruckman

Now THAT was a reasonable response. First one I’ve seen that explained the issue. (Not doubting there have been others, just saying this is the first I’ve seen.) Now the facts are perfectly clear for all you have my sincere apology as well. I'm too used to being blown off and watching others be blown off with snobbery, smart remarks, and rude answers. This thread was all I had read and it felt like more of the same. Being a dad myself I get the lack of time. Again, My apologies.

Meledosia avatar Aug 23 '19 23:08 Meledosia

I don't think this needs to be fixed, however, it might scare some people.

Jayderp avatar Oct 09 '19 10:10 Jayderp

Here's the more interesting thing about this warning: I have 2 identical servers, one production other development. same worlds etc. I do my coding on the development and move it to production after testing. The development has the error and the production does not.

Meledosia avatar Oct 10 '19 09:10 Meledosia

...2 identical servers... It's a WARN, not an ERROR. Same Java version?

SlimeDog avatar Oct 10 '19 14:10 SlimeDog

I did say warning but as far as I'm concerned if it shouldn't happen its an error. The only difference is severity. Nit picked? And yes, identical sort of means "the same".

Meledosia avatar Oct 11 '19 08:10 Meledosia

I'm sure you're on top of it all. However, "identical servers" is ambiguous. It could refer to the Spigot/MC servers, the underlying stack (OS and Java and etc), firmware, hardware, some of that list, or all of that list. It is reasonable to ask for clarification. Thanks for confirming that you meant "the entire system" top-to-bottom.

And if I may wax pedantic, by "identical" we mean "identically configured". Even if one system starts as a clone of another, as soon as they are running, they are no longer strictly identical.

SlimeDog avatar Oct 11 '19 12:10 SlimeDog

In every way meaningful to this topic they are identical. For the lawyers out there is means: Same Physical server box Same underlying game configuration Same software version Copies of the same maps All the same plugins and all on their same versions. Same keyboard Same mouse Same operator Same room Same town Started at as close to the same time as reasonably possible Same Same Same

OR we could just say "Identical Servers", so much simpler.

Meledosia avatar Oct 12 '19 13:10 Meledosia

Yes, we got it. Keep your lawyer pants on. I cannot begin to count the number of times in these support situations that "identical" has migrated to something like "completely the same ... no really ... um ... except (oops!) I forgot to mention that one is running 1.14.1 and the other 1.14.4. But otherwise the same." Thus the questions.

It is safe to say that, if the two systems were identical, the anomaly would not exist. So perhaps someday you will identify the (subtle) difference, and all will become clear. Or perhaps not.

SlimeDog avatar Oct 12 '19 14:10 SlimeDog

All, I decided to get to the bottom of why I saw this message on 1 of 2 "identical" servers. I compared line by line all of multiverse config and world files. all matched exactly. Made no sense. So I backed up and began looking at other configuration files and I found it.

In Bukkit.yml look for this line: deprecated-verbose: default change to deprecated-verbose: false Doesn't "fix" the depreciated code but will at least remove the message.

Meledosia avatar Nov 23 '19 11:11 Meledosia

Thanks for reporting. Not surprised that "identical" meant "nearly identical".

SlimeDog avatar Nov 23 '19 11:11 SlimeDog

@GCD56 nice find!

dumptruckman avatar Dec 03 '19 03:12 dumptruckman

@EbonJaeger Did you not read the thread before posting? They can't fix this right now, apparently the event was depreciated without an alternative. It wouldn't be the first time. So I posted the work around if the message bugs you:

In Bukkit.yml look for this line: deprecated-verbose: default change to deprecated-verbose: false Doesn't "fix" the depreciated code but will at least remove the message.

Meledosia avatar Dec 08 '19 12:12 Meledosia

@GCD56 What in the world are you on about? Was simply linking the duplicate issue to this one.

EbonJaeger avatar Dec 08 '19 15:12 EbonJaeger

Hi, it does the same thing in PaperSpigot 1.15.

x9nico avatar Dec 14 '19 18:12 x9nico

Hi, it does the same thing in PaperSpigot (build 26) 1.15.1

Nogapra avatar Dec 22 '19 16:12 Nogapra

So set the flag to false and you won’t have to see it.

From: LECURIEUX-CLERVILLE Aurélien [mailto:[email protected]] Sent: Sunday, December 22, 2019 10:07 AM To: Multiverse/Multiverse-Core [email protected] Cc: Guy Desroches [email protected]; Mention [email protected] Subject: Re: [Multiverse/Multiverse-Core] Deprecated EntityCreatePortalEvent (#2000)

Hi, it does the same thing in PaperSpigot (build 26) 1.15.1

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Multiverse/Multiverse-Core/issues/2000?email_source=notifications&email_token=AE2VFUK3P2IXCROZPIJOLIDQZ6GAPA5CNFSM4HOLYP2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHPTHVA#issuecomment-568275924 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2VFUKAJZJR5WXNP32B5JLQZ6GAPANCNFSM4HOLYP2A .

Meledosia avatar Dec 23 '19 10:12 Meledosia

WARN "Multiverse-Core v4.1.0-b775" has registered a listener for org.bukkit.event.entity.EntityCreatePortalEvent on method "public void com.onarandombox.MultiverseCore.listeners.MVPortalListener.entityPortalCreate(org.bukkit.event.entity.EntityCreatePortalEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [Rigby, fernferret, lithium3141, main--, dumptruckman].

misterwidescreen avatar Apr 15 '20 08:04 misterwidescreen

[11:10:07] [Server thread/INFO]: [Multiverse-Core] We are aware of the warning about the deprecated event. There is no alternative that allows us to do what we need to do. The performance impact is negligible. The line right after that warning ^^

This is not an issue, and you do not worry about it. Thanks!

benwoo1110 avatar Apr 15 '20 08:04 benwoo1110

@benwoo1110 You are totally right! I only saw the warning and thought "I had to report" haha xD guys you already know this just a reminder then I guess Kappa. Stay safe and healthy!

misterwidescreen avatar Apr 15 '20 08:04 misterwidescreen

just a reminder then

Yep makes absolutely sense to post the error without any comment in an issue that explains in depth why it's fine

ljacqu avatar Apr 18 '20 06:04 ljacqu

You know the programmer doesn’t even play Minecraft any more right?

He maintains Multi-Verse as a kindness, do you really want to tick him off?

You think you have the right to possibly screw us all over something that isn’t even impacting your servers???

The error says all it can in the space available: A depreciated call that has yet to be replaced with something better.

Meledosia

From: ljacqu [mailto:[email protected]] Sent: Saturday, April 18, 2020 1:42 AM To: Multiverse/Multiverse-Core [email protected] Cc: Guy Desroches [email protected]; Mention [email protected] Subject: Re: [Multiverse/Multiverse-Core] Deprecated EntityCreatePortalEvent (#2000)

just a reminder then

Yep makes absolutely sense to post the error without any comment in an issue that explains in depth why it's fine

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Multiverse/Multiverse-Core/issues/2000#issuecomment-615611809 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2VFUO5UGVQSOQNZ5YMSRLRNFDSRANCNFSM4HOLYP2A .

-- This email has been checked for viruses by AVG. https://www.avg.com

Meledosia avatar Apr 18 '20 08:04 Meledosia