bevy_tween icon indicating copy to clipboard operation
bevy_tween copied to clipboard
verified publisher icon Multirious

Add AnimationBuilder::try_insert_tween_here

Open baozaolaoba-top opened this issue 9 months ago • 1 comments

Maintain a consistent usage pattern, especially when destroying entities.

baozaolaoba-top avatar May 06 '25 02:05 baozaolaoba-top

Could you resolve the conflicts? Thanks.

Multirious avatar May 07 '25 07:05 Multirious

@Multirious please review

baozaolaoba-top avatar May 28 '25 02:05 baozaolaoba-top

@Multirious This is update to v0.9.1. Please let me know if any adjustments are needed. Thanks.

baozaolaoba-top avatar Aug 11 '25 03:08 baozaolaoba-top

@Rabbival Could you review this PR?

baozaolaoba-top avatar Aug 18 '25 09:08 baozaolaoba-top

@Rabbival Could you review this PR?

That's a lot of line changes and I don't have context. I will read and let you know my thoughts, but it would be helpful if you summerized your changes with such a big PR

Rabbival avatar Aug 18 '25 13:08 Rabbival

Update: I found out (using a diff checker) that github's diff algorithm was being funny. The only new thing in your function is try_insert for commands instead of insert

Rabbival avatar Aug 18 '25 13:08 Rabbival