VaultSharp.Extensions.Configuration icon indicating copy to clipboard operation
VaultSharp.Extensions.Configuration copied to clipboard
verified publisher icon MrZoidberg

Add support for v1 secrets engine.

Open oliverw opened this issue 4 years ago • 4 comments

This PR implements support for the v1 KV secrets engine.

oliverw avatar Dec 10 '21 10:12 oliverw

@oliverw Thanks for your PR. Looks good. How about using inheritance for VaultConfigurationProvider.cs? I think it can make a code a bit cleaner.

MrZoidberg avatar Dec 11 '21 12:12 MrZoidberg

It would be great to have some tests. You would need Docker to run integration tests.

MrZoidberg avatar Dec 11 '21 12:12 MrZoidberg

It would be great to have some tests. You would need Docker to run integration tests.

Will do.

oliverw avatar Dec 16 '21 10:12 oliverw

@oliverw Thanks for your PR. Looks good. How about using inheritance for VaultConfigurationProvider.cs? I think it can make a code a bit cleaner.

Working on it.

oliverw avatar Dec 16 '21 10:12 oliverw