hello.js icon indicating copy to clipboard operation
hello.js copied to clipboard

Updated LinkedIn Authorization URLs, no longer Legacy urls

Open WesMC opened this issue 8 years ago • 5 comments

I noticed that the URLS for the linkedIn Oauth are considered legacy per here: https://developer.linkedin.com/docs/oauth2-legacy

I simply replaced the links with their current modern counterpart per here: https://developer.linkedin.com/docs/oauth2

WesMC avatar Mar 29 '17 19:03 WesMC

This is slightly more complicated to change. The grant_url is stored and verified by the proxy server which handles the exchange of the Authorization Code for the Access Token. Otherwise as HelloJS sits in the client it could quite easily ask the Proxy server to send the Client Secret to another address. Therefore obtaining it.

... so basically everyone is going to have to change this in 2 places. Perhaps i could verify the domain and protocol rather than the full path.

MrSwitch avatar Apr 12 '17 17:04 MrSwitch

See also https://github.com/MrSwitch/node-oauth-shim/issues/23

MrSwitch avatar Apr 20 '17 22:04 MrSwitch

Hey @MrSwitch, I know its like asking "how long is a piece of string?" But any rough idea when you'll get a chance to look at your proxy server to enable this?

zerosimms avatar Apr 28 '17 11:04 zerosimms

Hey @MrSwitch, Would you you please let us know how much time it would take to solve this issue. So that linkedin social login will work.

jyotigupta007 avatar Feb 12 '18 10:02 jyotigupta007

@jyotigupta007 sorry not had a chance.

MrSwitch avatar Feb 21 '18 13:02 MrSwitch