Fix NPE getting range on NeoForge platform

Open PersonTheCat opened this issue 1 year ago • 4 comments

These changes tolerate config values with custom predicates on the NeoForge platform. Previously, this would have thrown a NullPointerException.

Jun 04 '24 15:06 PersonTheCat

I am currently still testing these changes and a second fix which will follow in a different PR. Will need a little more time to confirm.

Jun 04 '24 15:06 PersonTheCat

Confirmed fix in original project and added test coverage for both platforms. Please review.

Jun 04 '24 16:06 PersonTheCat

Thanks for this, however the code is trying to accomplish more than the PR is describing. If this can be refactored to only be a fix for the NPE when getting the range, I can merge.

Jun 23 '25 04:06 MrCrayfish

@MrCrayfish I removed changes to the build configuration and dependency upgrades.

Edit: Just wanna add that I am not able to build without these changes, but this does simplify the diffs.

Jun 23 '25 20:06 PersonTheCat