gestalt icon indicating copy to clipboard operation
gestalt copied to clipboard

use version expressions for dependency declarations

Open keturn opened this issue 4 years ago • 2 comments

  • [ ] Is it worth keeping the existing VersionRange class at all, or should we convert entirely?
  • [ ] Instead of building an expression out of minVersion, should we allow module metadata to define its own expression?
    • We would need to use the Maven-style expressions in that case in order for compile-time dependency resolution to still work.

Follow-up from #101.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

keturn avatar May 01 '21 18:05 keturn

ah, the Maven expressions are implemented in the antilaby fork. That explains why I couldn't find them in the upstream zafarkhaja sources.

Unfortunately, the confusing incrementMajorVersion behavior is also from the antilaby fork https://github.com/AntiLaby/jsemver/commit/f9fee4244d5f6034d892639465eb5ffb749c9569

"1.0.0-alpha".incrementMajorVersion() == "1.0.0"
"1.2.0-alpha".incrementMajorVersion() == "2.0.0"

without really any attached issue documentation to explain why.

keturn avatar May 03 '21 02:05 keturn

here is a different implementation entirely: https://github.com/vdurmont/semver4j

Its Ivy-mode looks like it is intended to be gradle-compatible.

keturn avatar May 03 '21 02:05 keturn