mostly-adequate-guide icon indicating copy to clipboard operation
mostly-adequate-guide copied to clipboard

Adding missing find function, fixes #564

Open dotnetCarpenter opened this issue 5 years ago • 2 comments

find is referenced in chapter 8 and is needed for the IO example:

// findParam :: String -> IO Maybe [String]
const findParam = key => map(compose(Maybe.of, find(compose(eq(key), head)), params), url);

This implementation of find only works for Array which is also the type of params in the example. params :: String -> [[String]]

dotnetCarpenter avatar Jan 27 '21 22:01 dotnetCarpenter

@KtorZ should I reinstate the white-spaces in appendix_c.md before this PR can be accepted?

dotnetCarpenter avatar Feb 19 '21 12:02 dotnetCarpenter

@dotnetCarpenter no worries here. These are indeed extraneous. A double-whitespace marks a newline in markdown (probably should use an explicit <br> instead...) but in this case they are simply superfluous.

I've been busy with other stuff lately and didn't give much time to reviews which required more than a quick eye-check. I'll allocate some time soon-ish to go through some open PRs and issues on this project.

KtorZ avatar Feb 19 '21 13:02 KtorZ