Winapp2 icon indicating copy to clipboard operation
Winapp2 copied to clipboard

Saved RDP connections removed

Open arisudesu opened this issue 1 year ago • 3 comments

[Windows Remote Desktop *]
LangSecRef=3025
Detect=HKCU\Software\Microsoft\Terminal Server Client
FileKey1=%UserProfile%\Documents|*.rdp

Please do not do *.rdp in documents! This is destructive. It should be enough to remove Documents\Default.rdp only.

I had customized RDP files in my docs dir, now they are gone, not something I expected. 😥 Please refrain from using globs like this in user profile.

arisudesu avatar Jun 12 '24 13:06 arisudesu

I think we should be doing this in Winapp2.ini and with a warning, because this seems to be very dangerous.

jensdraht1999 avatar Feb 17 '25 23:02 jensdraht1999

@jensdraht1999 are there cases when .rdp files in Documents should be matched by a wildcard? Instead of the known filename Default.rdp, are there other names for temporary files?

arisudesu avatar Jun 12 '25 22:06 arisudesu

I am not sure to be honest, since I have not added the entry myself. However, I think a warning should definlty be made for this.

jensdraht1999 avatar Jun 17 '25 17:06 jensdraht1999

In an upcoming release of winapp2.ini this entry is slated to be renamed [Windows Remote Desktop Saved Connections *] while still destroying all RDP files in the Documents folder. Is this name change clarifying or should the cleaning rule be changed to target only the Default connection?

MoscaDotTo avatar Aug 28 '25 19:08 MoscaDotTo

What's the point in removal of all saved connections files, again? They're not garbage files that could be just removed, think of them as shortcuts to connect to remote servers that user can save on his PC for later use; or similar to .lnk files on the desktop: they're usually not considered garbage. Neither do other files, like .bat files, .url files etc.

The only file that can be considered garbage is Default.rdp, which is hidden by default in explorer, and contains last used parameters from Remote Desktop Connection app. It is usually safe to remove. Everything else that must be either removed with a clear warning telling about it, or left untouched. As a general rule, anything in user-accessible directories that are not intended for use by apps exclusively, must not be touched unless explicitly warned.

arisudesu avatar Sep 03 '25 08:09 arisudesu

I will revise this to only target default.rdp in the next update :)

MoscaDotTo avatar Sep 05 '25 17:09 MoscaDotTo

this is fixed as of today

MoscaDotTo avatar Sep 21 '25 21:09 MoscaDotTo