Moore-AnimateAnyone icon indicating copy to clipboard operation
Moore-AnimateAnyone copied to clipboard

The issue of mse_loss_weights related to snr

Open haohang96 opened this issue 1 year ago • 0 comments

According to the official implementation of min-snr, in v-parametrization, the mse_loss_weight shall be (Ref to this line: code-url):

$$min(snr, \gamma) / (snr + 1)$$

But in your implementation, it is: (Ref to this line: code-url)

$$min(snr+1, \gamma) / (snr +1)$$

It's because you do add one before mse_loss_weight computation.

haohang96 avatar Jun 06 '24 11:06 haohang96