refactor: release fixes
- remove Get_rendering module
- update usage of vfo module in docs and code
Codecov Report
Attention: Patch coverage is 47.43590% with 41 lines in your changes missing coverage. Please review.
Project coverage is 86.80%. Comparing base (
cc0fb4a) to head (3e1776a). Report is 4 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 87.30% 86.80% -0.50%
==========================================
Files 16 16
Lines 4522 4571 +49
==========================================
+ Hits 3948 3968 +20
- Misses 574 603 +29
| Files | Coverage Δ | |
|---|---|---|
| src/ospgrillage/__init__.py | 100.00% <100.00%> (ø) |
|
| src/ospgrillage/mesh.py | 91.42% <100.00%> (-0.01%) |
:arrow_down: |
| src/ospgrillage/postprocessing.py | 89.11% <100.00%> (-0.08%) |
:arrow_down: |
| src/ospgrillage/utils.py | 88.85% <ø> (ø) |
|
| tests/test_load.py | 100.00% <100.00%> (ø) |
|
| tests/test_osp_grillage.py | 97.02% <ø> (ø) |
|
| src/ospgrillage/members.py | 78.44% <66.66%> (-0.50%) |
:arrow_down: |
| src/ospgrillage/osp_grillage.py | 80.67% <31.03%> (-1.53%) |
:arrow_down: |
@justinngan92 can you check this PR and rebase onto #74 please?
Thanks @justinngan92 . Can you explore the reason for the tests failing please? Do these changes mean the tests need to be updated or are there bugs in the changes?
@ccaprani Its because the test suites use numpy 2.0. I think its changing the requirement to <2.0 here should work?
@justinngan92 Yes, for now we may need to change the requirement to numpy ~= 1.26 so that all tests pass and we can solve the other issues. Afterwards, we should then work on adapting the code to be valid for numpy 1.x and 2.x if possible.
@justinngan92 is this ready? It's failing the tests though?