python-web-scraping icon indicating copy to clipboard operation
python-web-scraping copied to clipboard

Simplify variable names

Open satyaborg opened this issue 5 years ago • 4 comments

Readability aspects

satyaborg avatar Aug 18 '20 02:08 satyaborg

Just to add to this, equity should be changed to x or some more generic name in the Wrangling ntoebook so that later when students are trying to do the challenge they don't go through so much trouble of changing each variable.

aryanfaghihi avatar Aug 18 '20 02:08 aryanfaghihi

I thought of working on this issue and had a look at the notebook. In order to change the notebook in such a way that there is a minimal change for the final challenge of equity, we will have to convert all the asset related variable to generic names which are at a lot of places and I don't think is a good idea, based on a good variable naming practice.

Maybe, let the attendees work through by copy-pasting the code and making the necessary changes which may result in a little loss of time, but would help them in having a better understanding? Thoughts? @satyaborg @aryanfaghihi

naveenkaushik2504 avatar Sep 07 '20 10:09 naveenkaushik2504

That is a fair point, struggling with the code is how you learn. I'm just worried that they might get frustrated in the process but given they are mostly PhD students, I'm sure they are used to pushing through challenges.

aryanfaghihi avatar Sep 08 '20 01:09 aryanfaghihi

All valid arguments. Let me take another stab at the code and see if we can't simplify things any further. It should ideally leave us with fewer variables and a much more concise naming scheme.

satyaborg avatar Sep 08 '20 13:09 satyaborg