Reinvent icon indicating copy to clipboard operation
Reinvent copied to clipboard

Complete Use Case in Reinvent Community

Open dd1github opened this issue 4 years ago • 6 comments

Hi, the Complete Use Case example appears to be missing the drd2.pkl file. When I used the old drd2.pkl file (from a download from a few days ago), the file raised an error, ModuleNotFoundError: No module named 'sklearn.ensemble.forest'. I believe this is because sklearn changed the name of this model to sklearn.ensemble._forest. Can you please provide an updated drd2.pkl file that works with the Use Case Example? Thanks.

dd1github avatar Sep 28 '21 18:09 dd1github

Hi, thanks for reporting this. The file has been moved to: https://github.com/MolecularAI/ReinventCommunity/tree/master/notebooks/models @GuoJeff could you please update this example: https://github.com/MolecularAI/ReinventCommunity/blob/master/notebooks/Complete_Use-Case-DRD2_Demo.ipynb it points to /data/drd2.pkl instead of pointing to /models/drd2.pkl

patronov avatar Sep 29 '21 23:09 patronov

Hi @dd1github,

I have changed the path and re-uploaded the previously corrupt drd2.pkl model.

GuoJeff avatar Oct 02 '21 12:10 GuoJeff

Thanks, but this still does not work.

It still returns the same error

Exception: The loaded file .../drd2.pkl isn't a valid scikit-learn model

I believe that the drd2 file was created in an old version of scikit learn and therefore does not work.

Best, Damien

On Wed, Sep 29, 2021 at 7:14 PM patronov @.***> wrote:

Hi, thanks for reporting this. The file has been moved to:

https://github.com/MolecularAI/ReinventCommunity/tree/master/notebooks/models @GuoJeff https://github.com/GuoJeff could you please update this example:

https://github.com/MolecularAI/ReinventCommunity/blob/master/notebooks/Complete_Use-Case-DRD2_Demo.ipynb it points to /data/drd2.pkl instead of pointing to /models/drd2.pkl

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MolecularAI/Reinvent/issues/33#issuecomment-930613185, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFZYGM5GA4U2U3UT7FOSO3UEOMVRANCNFSM5E6CPEUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

dd1github avatar Oct 03 '21 22:10 dd1github

Which version of scikit are you using? Is it scikit-learn=0.21.3 ?

patronov avatar Oct 03 '21 22:10 patronov

I am using 0.24.2

Best, Damien

On Sun, Oct 3, 2021 at 6:36 PM patronov @.***> wrote:

Which version of scikit are you using? Is it scikit-learn=0.21.3 ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MolecularAI/Reinvent/issues/33#issuecomment-933036731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFZYGPRT43LYSMTOY2I3E3UFDLGFANCNFSM5E6CPEUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

dd1github avatar Oct 03 '21 22:10 dd1github

Current models are compatible with up to 0.21.3 They wont work with newer versions.

In the future we will aim to become compatible with the recently released v 1.0 of scikit-learn but this may require to adapt to potential changes of the interface. Havent had the chance to review it yet.

Best,

Atanas

patronov avatar Oct 03 '21 22:10 patronov