ModManagerMC
[BUG] Updating mods randomly fail to download, making Minecraft not launchable
Describe the bug Updating mods using Mod Manager have a chance to fail, it seems completely random from my observations. I noticed that clicking "Update All" has the highest chance for the bug to happen, but that may be a coincidence.
To Reproduce Steps to reproduce the behavior:
- Download an update for an installed mod
- Observe a mod downloading for infinite amount of time (happening of this step seems to be completely random)
- Backing out and updating it again will bring instantly an error telling something about jar being missing but I am not sure what it said exactly (I'll try to find exact message later and fill it out)
- Minecraft then won't launch as a mod is not downloaded properly and Fabric spills an error
Expected behavior Mod should be just updated.
Please complete the following information:
- OS: Linux
- Minecraft version: 1.18.1
- Version 1.2.2+1.18
Logs
Latest log: 2022-02-16-2.log I think the most important thing in that log starts at line 1031
Additional context I found that the failed downloaded file was 0B in size. I have in idea for a work around this issue. If I understand it correctly, this mod removes the original file and then downloads new one directly into mods folder. To prevent that issue affecting launching the game, this mod could download the mods first into temporary folder and when everything downloads correctly, it will remove original files and just move already downloaded files into mods folder. It could check if file size is at least like 5B or something to determine if mod was downloaded correctly or not.
ModManager needs to verify the hash even when an exception was thrown. This means ModManager needs to cleanup after himself.
I just tried to download 4 updates: Indium, InvMove, Lithium, SleepWarp. All of them failed, I tried one by one and they spilled out errors. This may be related to Modrinth as it got updated lately maybe something changed about it. Mod thumbnails are also not downloading at all. Also, InvMove and SleepWarp files were completely removed, while Indium and Lithium were in this weird 0B state.
I'm currently working on a new version of ModManager which will let the most things be handeld by a backend server. The new version will also download mods more securely and makes sure it doesn't break something