gtfs-validator icon indicating copy to clipboard operation
gtfs-validator copied to clipboard

Manual dispatch of workflows

Open bdferris-v2 opened this issue 3 years ago • 5 comments

This allows for manually executing acceptance and end-to-end workflows.

bdferris-v2 avatar Feb 03 '23 00:02 bdferris-v2

✅ Rule acceptance tests passed. New Errors: 0 out of 1389 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 0 out of 1389 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. 0 out of 1389 sources (~0 %) are corrupted. Commit: 00ce5d1955870f0da1d6f9c89bb58f1b2996372e Download the full acceptance test report here (report will disappear after 90 days). ✅ Rule acceptance tests passed.

github-actions[bot] avatar Feb 03 '23 01:02 github-actions[bot]

@isabelle-dr this might be a better alternative to manual PRs like #1347 when you want to run the acceptance workflows

bdferris-v2 avatar Mar 06 '23 16:03 bdferris-v2

Thank you! Definitely a better alternative 🙃

isabelle-dr avatar Mar 06 '23 23:03 isabelle-dr

What would it mean in practice? For example, if I needed to do what I did in #1347 (see how many datasets trigger a particular error) with the updates you made in this PR, what would I do differently?

isabelle-dr avatar Mar 06 '23 23:03 isabelle-dr

So I think there is still a bit of code I would write to help you here. Specifically, I would output the mapping for validation notices => feeds in the output comparator as an additional output. Then you could see the set of notices as generated against the master branch for each run.

(I had thought something like this already existed in the output, but after looking closer, it doesn't output quite what you need).

bdferris-v2 avatar Mar 06 '23 23:03 bdferris-v2