gtfs-validator icon indicating copy to clipboard operation
gtfs-validator copied to clipboard

Docs: Update rules.md stop_times.txt best practices reference link

Open mrajen27 opened this issue 3 years ago • 4 comments

Updating the Rules.md documentation to fix the stop_times.txt best practices reference link 404 error.

In RULES.md, the link stop_times.txt best practices provided in the missing_timepoint_column notice is broken. Additionally, the Best Practice has no mention of timepoint, think link should refer to the specification instead.

It should be replaced by the following link:

https://gtfs.org/schedule/reference/#stop_timestxt

mrajen27 avatar Aug 11 '22 19:08 mrajen27

Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:

  • fix: Bug with ssl network connections + Java module permissions.
  • `feat: Initial support for multiple @PrimaryKey annotations.
  • docs: update RELEASE.md with new process To get this PR to the finish line, please do the following:
  • Read our Contribution Guidelines
  • Follow Google Java style coding standards
  • Include tests when adding/changing behavior
  • Include screenshots

welcome[bot] avatar Aug 11 '22 19:08 welcome[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Magesh Rajendiran seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 11 '22 19:08 CLAassistant

Hello @mrajen27, thank you for fixing this issue so quickly! I left one comment requesting a change, besides this, it looks good 😊.

Another thing: could you please sign the CLA agreement.

Thanks for your participation in open source software!

isabelle-dr avatar Aug 12 '22 10:08 isabelle-dr

@mrajen27, are you planning to continue working on this PR?

isabelle-dr avatar Sep 16 '22 13:09 isabelle-dr

Closing, this is being solved in #1295. @mrajen27, we hope to see you around on other issues! 😊

isabelle-dr avatar Nov 22 '22 21:11 isabelle-dr