RecTools icon indicating copy to clipboard operation
RecTools copied to clipboard

feat: Use pm-implicit with Cuda12.x

Open chezou opened this issue 3 months ago • 2 comments

Description

This PR allows to use Cuda 12.x for implicit on Python 3.10+ environment by using pm-implicit, forked version of implicit built with CUDA 12.9.

This reduces build time of implicit wheel for Python 3.12 and 3.13 since official implicit distributes wheels until 3.11.

Note that Python 3.9 was EoL on Oct 25, 2025, so that pm-implicit excludes 3.9 support.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

chezou avatar Nov 24 '25 22:11 chezou

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 100.00%. Comparing base (9b3992e) to head (59a82c9). :warning: Report is 122 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #298     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        82     +37     
  Lines         2242      5650   +3408     
===========================================
+ Hits          2242      5650   +3408     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 24 '25 22:11 codecov[bot]

@feldlime @blondered Can you review when you have a chance?

I confirmed all the implicit tests has been passed with pm-implicit.

chezou avatar Dec 05 '25 04:12 chezou