XCLogParser icon indicating copy to clipboard operation
XCLogParser copied to clipboard

Skip parsing of section attachments for logs with version less than 11

Open HeEAaD opened this issue 1 year ago • 2 comments

Fixes #211 Fixes #209

This resolves the regression introduced by #204 that parsing of older logs (pre Xcode 15.3) raises the error Unexpected token parsing array of IDEActivityLogSectionAttachment.

Parse the IDEActivityLogSectionAttachments list only for activity logs with version 11 or above because this list is missing in version 10 logs.

Thanks @yohunl for the inspiration for the fix. https://github.com/MobileNativeFoundation/XCLogParser/issues/209#issuecomment-2055828404

HeEAaD avatar Jul 31 '24 15:07 HeEAaD

@polac24 @ecamacho @aleksandergrzyb @CognitiveDisson Hi guys! Could you please review this pull request? It's impossible to use XCLogParser on Xcode before 15.3 without it.

MasterWatcher avatar Sep 13 '24 11:09 MasterWatcher

Up! @polac24 @ecamacho @aleksandergrzyb @CognitiveDisson Hi guys! Could you please review this pull request?

giovaninb avatar Oct 18 '24 19:10 giovaninb

Up! @polac24 @ecamacho @CognitiveDisson please 🙏

rcek2 avatar Oct 28 '24 08:10 rcek2

@HeEAaD not sure why, but the checks fail with couldn't find remote ref refs/pull/213/merge. In #218 I updated the checkout action version, could you rebase?

aleksandergrzyb avatar Nov 13 '24 12:11 aleksandergrzyb

@HeEAaD I was able to pull your branch and build locally and this fixes an issue I have. Is there any chance you could re-base so we could get this merged and a new version cut?

kalebhermes avatar Dec 10 '24 16:12 kalebhermes

@aleksandergrzyb @kalebhermes I've just rebased. Unit tests succeeded locally.

Please approve the workflow run.

HeEAaD avatar Dec 10 '24 17:12 HeEAaD

We also had to upgrade macOS version, could you rebase on #222?

aleksandergrzyb avatar Dec 11 '24 09:12 aleksandergrzyb

We also had to upgrade macOS version, could you rebase on #222?

done

HeEAaD avatar Dec 11 '24 09:12 HeEAaD