MobBotTeam
Removed static classes
Removed static classes and injecting the classes with constructor injection. Next steps could be:
- clean up tasks, quite a lot of duplicated code
- write unit test for important services/tasks
- .... there is enough to do ;)
Does git have a hook for running tests on commit/push/pr? I have also thought about adding tests for things, but after working in the real world, no one manually runs tests - there are systems in place to do that for you before submitting/while review iterating/etc. Otherwise I foresee those tests going ignored soon after being introduced
Github doesn't as far as I know. We could link a the repo to a tfs online server and build it and run the tests there, but it's not free :/ There was an option like that in the past, but I'm not able to find it in visual studio 2015.
I will resolve the conflicts tonight.
Awesome, you took quite off some work from me:) Please fix the outstanding conflicts @rfaes
About running tests on commit/push/pr you should add some hooks, maybe to run a install.sh which generates some hooks under .git/hooks, pre-commit and pre-push, and maybe using travis-ci to check PRs (https://docs.travis-ci.com/user/languages/cpp). Hope it helps :)
not sure but after reading up on static and checking the file, this might also solve #434 :)
https://www.appveyor.com/ could do automatic build checks and testing. And it is free for open-source projects
I've used myget previously. It was prety good. http://docs.myget.org/docs/reference/build-services
There are now cyclical dependencies again -.- ApiFailureStrategy and Client are the trouble makers. I try to fix it now.
I don't get usable pokestops close to me, can somebody please check?
Removed conflicts. Can't really test it at the moment... @Jazed please reopen pr.
guess that has nothing to do with the branch ;) Could not find .travis.yml, using standard configuration.