Build failure on platforms where char is unsigned

Open andylee830914 opened this issue 5 years ago • 1 comments

Refer to the issues in mmg https://github.com/MmgTools/mmg/issues/83 I got the same compilation error in parmmg on arm platform. I think it is the same issue.

In file included from /home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/inoutcpp_3d.cpp:37:
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:149:93: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
  149 | _idirinv[4][4] = {{-1,0,1,2},{0,-1,2,1},{0,1,-1,2},{0,2,1,-1}};
      |                                                              ^

/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:149:93: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:149:93: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:149:93: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
  153 | -1,2,1,0}, {-1,1,2,-1,-1,0},{2,-1,1,-1,0,-1},{1,2,-1,0,-1,-1}};
      |                                                              ^

/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]
/home/ubuntu/ParMmg/build/Mmg-prefix/src/Mmg/src/mmg3d/mmg3d.h:153:119: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]

Oct 19 '20 06:10 andylee830914

Hi,

For now ParMmg is not fully compatible with the last release of Mmg so it is not possible to checkout a Mmg version version where the compilation error is corrected.

We will keep you aware when the last release of Mmg will be compatible with ParMmg.

Best Regards, Algiane

Oct 19 '20 07:10 Algiane