mithril.js icon indicating copy to clipboard operation
mithril.js copied to clipboard

Release - v3.0.0

Open JAForbes opened this issue 3 years ago • 4 comments

Release v3.0.0

  • #2793
  • #2790
  • #2762
  • #2782
  • #2786
  • #2785
  • #2781
  • #2779
  • #2746
  • #2764

Changelog

Major Changes

Actually remove ospec from the main code base (@pygy)

It is still used as a dev-dependency.

Kick promise polyfill (@StephanHoyer)

allow trailing slash for routes - fixes #2763 (@StephanHoyer)

Minor Changes

implement m.domFor() and use it internally to move and remove nodes. Fix #2780 (@pygy)

Add m.domFor(vnode). This adds m.domFor(vnode) as described in #2780 (with a twist to deal with node removal between iterations).

Patch Changes

Fix silent build error in next: bundler can't handle multiple exports per module (@barneycarroll)

The domFor patch breaks the compiled output: the bundler can't handle multiple exports per module. 1.

Bump shell-quote from 1.7.2 to 1.7.3 (@dependabot[bot])

Bumps shell-quote from 1.7.2 to 1.7.3. Changelog. Sourced from shell-quote's changelog. 1.7.3.

Bump minimist from 1.2.5 to 1.2.6 (@dependabot[bot])

Bumps minimist from 1.2.5 to 1.2.6. Commits. 7efb22a 1.2.6.

Add back CI (@pygy)

Enable CI that was I suppose disabled by mistake.

Add missing prerelease branch target. (@JAForbes)

Addresses this issue https://github.com/JAForbes/pr-release/issues/345 (raised by @pygy).

Kick jsonp - fixes #2682 (@StephanHoyer)

Kick JSONP. I removed all stuff related to jsonp. It's only rarely used nowadays, If anyone needs it, there are plenty of alternative packages.

JAForbes avatar May 30 '22 06:05 JAForbes

⚠⚠⚠ Hey @JAForbes, did you mean to open this against next? ⚠⚠⚠

github-actions[bot] avatar May 30 '22 06:05 github-actions[bot]

@JAForbes the pr action failed here, not sure what happens or if I can re-run it safely...

pygy avatar Jun 21 '22 15:06 pygy

@JAForbes the pr action failed here, not sure what happens or if I can re-run it safely...

Re-ran it and passed. I've seen it before and raised it with github support. Sometimes the PATCH endpoint returns a 404 erroneously.

To answer your question its safe to re-run the pr job.

JAForbes avatar Jun 21 '22 16:06 JAForbes

Great, thanks !

pygy avatar Jun 21 '22 16:06 pygy

@JAForbes I messed up with the v2.x branch and accidentally triggered pr-release to run from there, i.e. the wrong branch.

It would be nice if there were branch checks before doing irreversible operations (and possibly other idiot proofing measures).

Also, from here, how do we fix things up?

pygy avatar Jan 26 '23 11:01 pygy

Was the wrong version released as 2.2.3? :O

Prid13 avatar Jan 28 '23 17:01 Prid13

Yes, I messed up while setting up the v2.x branch and triggered the release script by accident (from a Github action that I hadn't read to the bottom).

It was up for about one hour and a half, I hope it didn't derail your workflow...

pygy avatar Jan 28 '23 17:01 pygy

No, not at all, was just testing Mithril when I noticed some changes that I had to investigate 😅

Oh, it's fixed already? Sadly the Mithril CDN link I found on Google as the top result still holds that wrong version: https://cdnjs.com/libraries/mithril :/

Prid13 avatar Jan 28 '23 19:01 Prid13

Oh, thanks for the heads up. Not sure I can solve this on their hand, short of pushing yet another release...

https://github.com/cdnjs/packages/issues/1450 ... We'll see how things go over there.

pygy avatar Jan 28 '23 19:01 pygy