cri-dockerd icon indicating copy to clipboard operation
cri-dockerd copied to clipboard

Switch container logging to a log driver

Open nwneisen opened this issue 2 years ago • 0 comments

Current Behavior

The current change made in #224 tails the log file created by docker. This works but there are some potential issues with it on windows.

Solution

A better setup would be to write a container log driver that cri-dockerd installs when it is installed. This log driver would write the log output to both the standard docker json file and the kube cri formatted file.

A fallback could also be setup, in case the driver isn't installed, which attaches to the container and streams the log output using https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerAttach or https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerLogs

nwneisen avatar Oct 03 '23 23:10 nwneisen