plugin-yml icon indicating copy to clipboard operation
plugin-yml copied to clipboard

generateLibrariesJson doesn't respect dependency classifier/extension

Open Galster-dev opened this issue 2 years ago • 5 comments

Exported dependency coords do not include classifiers and extensions. This leads to some bugs, e.g. server trying to download jar artifact for pom dependency (with PluginLoader implementation presented in README)

My personal workaround atm is exporting artifacts instead of dependencies, but you may not like it because of increased JSON file size.

Galster-dev avatar Aug 20 '23 05:08 Galster-dev

Could we just filter out pom dependencies completely?

stephan-gh avatar Aug 20 '23 12:08 stephan-gh

Some pom dependencies are meta packages containing a few jar artifacts

Galster-dev avatar Aug 20 '23 12:08 Galster-dev

My actual issue happened with InvUi (pom available here). This dependency unfolds to inventory-access-{r1-r14} and invui-core which are jar artifacts and required at runtime.

Galster-dev avatar Aug 20 '23 12:08 Galster-dev

How would you expect to handle these on the PluginLoader side? Does it provide the necessary functionality to parse & handle metadata packages?

stephan-gh avatar Aug 20 '23 12:08 stephan-gh

Yes, DefaultArtifact has both constructors with classifiers/extension and can parse it from a single so called "coords" string (format available here)

Galster-dev avatar Aug 20 '23 12:08 Galster-dev