ForgeFlower icon indicating copy to clipboard operation
ForgeFlower copied to clipboard

Add pattern matching instanceof

Open coehlrich opened this issue 3 years ago • 3 comments

22w11a diff 1.18.2-rc1 diff

Fixes the compile error where a generic is assigned into a variable with the type StringReader here in 22w11a.

Doesn't currently support the way ecj compiles pattern matching instanceof which does the cast twice and check if the casts are the same as well as registering the generated variable in the local variable table.

coehlrich avatar Mar 19 '22 05:03 coehlrich

Wouldn't a better solution be to rebase against upstream which in theory has had this support since early december? https://github.com/MinecraftForge/FernFlower/commit/91cf425e9b35d7cf4816d15ecc8a4422cba87d86

pupnewfster avatar Mar 19 '22 14:03 pupnewfster

Closing in favor of #114, thanks though!

zml2008 avatar May 24 '22 05:05 zml2008

This appears to be a draft because it supposedly has improvements over upstream which need to be rebased & reevaluated.

SizableShrimp avatar Jan 25 '23 19:01 SizableShrimp