FML icon indicating copy to clipboard operation
FML copied to clipboard

[1.8, Forge 1329] Sending packets with sendToAll kicks clients from server, error in console.

Open iChun opened this issue 10 years ago • 12 comments

Pretty much the same issue as #588, except it was supposed to have been fixed by now. Doesn't happen all the time now though as before, more like the every second or third time the same packet is sent.

Console error: https://gist.github.com/iChun/f13b71929ece691ddd0e

iChun avatar Mar 02 '15 04:03 iChun

Compleetly different issue. This one is caused by something malforming the packets and causing the header to look for a invalid packet by id. What are you sending? How much data is it? How are you sending it? Are you going beyond the data cap for the custom packets? How are you registering your packet system?

Get packet logs.

LexManos avatar Mar 02 '15 19:03 LexManos

I'm sending a packet of Strings and ints. At time the exception is thrown it most likely has 2 strings and an int. One of the strings are a UUID in form of string, the other is just a short one of length ~10.

Sending it by sendToAll found here: https://github.com/iChun/iChunUtil/blob/master/src/main/java/us/ichun/mods/ichunutil/common/core/network/PacketChannel.java#L41-L46

It's 2 strings and an int, no I don't think I'm going beyond the data cap.

Packet System registered in this function: https://github.com/iChun/iChunUtil/blob/master/src/main/java/us/ichun/mods/ichunutil/common/core/network/ChannelHandler.java#L45-L67

Packet logs?

iChun avatar Mar 03 '15 01:03 iChun

<Lex_> pig, imm -dfml.DebugHandshake=true i think.. i think that enables the packet logger i added...

iChun avatar Mar 04 '15 13:03 iChun

For future reference it's debugNetworkHandshake.

iChun avatar Mar 04 '15 14:03 iChun

Can't load a world if that's on. Console spits an error: https://gist.github.com/iChun/24a68f74f6d677382cb4

Game also hard locks if tried to quit from menu normally.

iChun avatar Mar 04 '15 14:03 iChun

You're doing something to corrupt the packet format, thats whats causing the errors. Give the EXACT code and EVERYTHING. Not the generic 'sendPacket' function as that tells me nothing about the packet being sent.

LexManos avatar Mar 04 '15 17:03 LexManos

Considering it happens with no mods installed, I don't think it's me. Full FML Log. https://gist.github.com/iChun/ac145d246ec159beea7a

iChun avatar Mar 04 '15 23:03 iChun

Did you try with the new debugging code? I believe lex fixed the debug issue causing a problem...

cpw avatar Mar 21 '15 18:03 cpw

I've not tried it yet, have not had the time to be deving anything as of late

On Sat, Mar 21, 2015 at 6:59 PM, cpw [email protected] wrote:

Did you try with the new debugging code? I believe lex fixed the debug issue causing a problem...

— Reply to this email directly or view it on GitHub https://github.com/MinecraftForge/FML/issues/608#issuecomment-84423073.

iChun avatar Mar 22 '15 14:03 iChun

Trying to load a world with network debug still keeps you locked in the main menu (with no mods). Forge 1344. https://gist.github.com/iChun/f3135cf04261eb4972a0

iChun avatar Mar 29 '15 09:03 iChun

This comes up when connected to a dedicated server instead. https://gist.github.com/iChun/1f7cb8afc1ba1c0db653

iChun avatar Mar 29 '15 23:03 iChun

LexManos: point is to track the packet as far as possible. From what you've done sofar the error lies somewhere between the client's splitter and the server's send queue.add

iChun avatar Mar 30 '15 02:03 iChun