ClientStats icon indicating copy to clipboard operation
ClientStats copied to clipboard

Plugin detects wrong version with ProtocolSupport + ViaVersion

Open Leymooo opened this issue 4 years ago • 2 comments

image

versions:
  '0': unknown
  '756': 1.17.1
  '755': '1.17'
  '754': 1.16.4, 1.16.5
   ...
   ....

Server is 1.16.5, client version is 1.17.1 but plugins shows 1.16.4 - 1.16.5

Leymooo avatar Jul 17 '21 00:07 Leymooo

~~the new ViaVersion API (4.0.1) fallbacks to ProtocolSupport API when return protocol version. https://github.com/ViaVersion/ViaVersion/blob/master/api/src/main/java/com/viaversion/viaversion/api/ViaAPI.java#L67~~

~~Current legacy API (us.myles.viaversion...) also fallbacks to new VV api https://github.com/ViaVersion/ViaVersion/blob/master/api-legacy/src/main/java/us/myles/ViaVersion/api/Via.java#L51, so i think you can simply remove getter from PS API and return version only from VV api https://github.com/MineTheCube/ClientStats/blob/master/src/main/java/fr/onecraft/clientstats/bukkit/hook/provider/ViaProtocolProvider.java#L26~~

Well, its not working. Dont know why but VV API does not return version from PS API, and just returns server version if client version is lower than server.

Leymooo avatar Jul 17 '21 00:07 Leymooo

I have the same problem. But i only use ViaVersion. The server itself runs on 1.16.5, but if i join with 1.17.1 it will say that my client is 1.16.4/1.16.5.

MennoGamed avatar Sep 20 '21 17:09 MennoGamed