raygun4node icon indicating copy to clipboard operation
raygun4node copied to clipboard

refactor: #158 fix eslint rule "no-unused-vars"

Open miquelbeltran opened this issue 1 year ago • 0 comments

refactor: #158 fix eslint rule "no-unused-vars"

Description :memo:

  • Purpose: Fixes the "no-unused-vars" lint rule.
  • Approach: Configured the rule and performed code changes.

To allow unused parameters, this rule sets the property args to none, that way the linter will not report errors for this case, e.g. here the req parameter would throw an error without this configuration:

raygunClient.user = function(req) {
    return '[email protected]';
};
  • Depends on #160

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

Updates

  • Continuing work from pr #160
  • Configure rule as explained.
  • Removed several unused variables.

Test plan :test_tube:

  • run ci scripts (test and lint)
  • todo: properly test with example apps, requires dependencies.

Author to check :eyeglasses:

  • [ ] Project and all contained modules builds successfully
  • [ ] Self-/dev-tested
  • [ ] Unit/UI/Automation/Integration tests provided where applicable
  • [ ] Code is written to standards
  • [ ] Appropriate documentation written (code comments, internal docs)

Reviewer to check :heavy_check_mark:

  • [ ] Project and all contained modules builds successfully
  • [ ] Change has been dev-/reviewer-tested, where possible
  • [ ] Unit/UI/Automation/Integration tests provided where applicable
  • [ ] Code is written to standards
  • [ ] Appropriate documentation written (code comments, internal docs)

miquelbeltran avatar Apr 26 '24 11:04 miquelbeltran