raygun4node icon indicating copy to clipboard operation
raygun4node copied to clipboard
verified publisher icon MindscapeHQ

chore: #148 upgrade examples

Open miquelbeltran opened this issue 1 year ago • 1 comments

chore: #148 upgrade examples

Description :memo:

Take the two examples in the repo and upgrade dependencies. Also ensure that they use the raygun4node found in the repo, not the one from npm.

Type of change

  • [x] Tech debt ;)

Updates

  • Upgrade dependencies in examples/express-sample.
  • Upgrade dependencies in examples/using-domains.
  • Ensure both examples use the raygun node package from the repo, not the one hosted in npm.
  • Adds multiple console.log to examples/using-domains.
  • Fixes indentation in examples/using-domains/app.js.

Note: The eslint config is done in #156 and includes the files in the examples folders.

Test plan :test_tube:

  • Run both examples.

Author to check :eyeglasses:

  • [x] Project and all contained modules builds successfully
  • [x] Self-/dev-tested
  • [x] Unit/UI/Automation/Integration tests provided where applicable
  • [x] Code is written to standards
  • [x] Appropriate documentation written (code comments, internal docs)

Reviewer to check :heavy_check_mark:

  • [ ] Project and all contained modules builds successfully
  • [ ] Change has been dev-/reviewer-tested, where possible
  • [ ] Unit/UI/Automation/Integration tests provided where applicable
  • [ ] Code is written to standards
  • [ ] Appropriate documentation written (code comments, internal docs)

miquelbeltran avatar Apr 24 '24 10:04 miquelbeltran

I didn't realise we had to build the provider first before building and running the app!

I've added that step now to the README

Do we need to explicitly point out the API Key change to ensure that the config value is changed to their API Key? Just to make it obvious to the user

I added now a check in both examples.

Not sure why, but the server just terminates when running npm start so the other option that worked was the manual run in terminal.

I did not have this issue, that's strange...

miquelbeltran avatar Apr 26 '24 05:04 miquelbeltran

Thank you for addressing those @miquelbeltran ! As for the local set up issues, I don't think this is tied to provider issues themselves but a problem on my computer. So no need to add additional information around how I addressed the problem

sumitramanga avatar Apr 28 '24 22:04 sumitramanga