googlebench: 'numeric_limits' is not a member of 'std'

[Klummel69]

Hi Mike

I finally have time to deal with fpm again. When I build the project via cmake the following error message appears:

[build] fpm/3rdparty/googlebench/src/benchmark_register.h:18:30: error: 'numeric_limits' is not a member of 'std'

[build]    18 |   static const T kmax = std::numeric_limits<T>::max(); 

Tested with

• GCC 14.2.0 x86_64-w64-mingw32
• Clang 18.1.8 x86_64-w64-windows-gnu
• GCC 11.4.0 x86_64-linux-gnu

The bug is a known issue and has been fixed in later googlebench versions. Workaround see https://github.com/google/benchmark/commit/3d1c2677686718d906f28c1d4da001c42666e6d2

File src/benchmark_register.h: add #include <limits>

Wouldn't it make sense to reload googlebench instead of keeping it in the repository?

Regards Klaus

[MikeLankamp]

Wouldn't it make sense to reload googlebench instead of keeping it in the repository?

By "reload" you mean use a Git submodule? I was actually thinking of switching fpm to Conan, would that make sense?

[Klummel69]

By "reload" you mean use a Git submodule?

Yes, I meant git submodule

I was actually thinking of switching fpm to Conan, would that make sense?

That would also be a possibility (although I have had little experience as a user with conan so far). Conan probably makes sense if there are many dependencies on large packages.

Addendum: I am currently testing different sin(), cos() variants regarding accuracy and speed. The current builds for accuracy and benchmark use external packages (libfixmath, libcnl), which I don't currently need. It would be practical if the accuracy / benchmark code was not so heavily dependent on the external packages. Since I want to do the evaluation with Jupyter Notebooks, I will create a test project that uses fpm as a submodule and contains my own test code.

As soon as I'm ready I'll put it on github.