Timer icon indicating copy to clipboard operation
Timer copied to clipboard

Some needed functionalities are missing

Open amirsaam opened this issue 1 year ago • 6 comments

Hello, First of all thanks for your effort on the package.

Since I am trying to use your Timer in my project, unfortunately lack of some functionalities are hardly noticed.

  1. When timer ends, timer needs to have a Bool to notify UI about it, isTimerRunning is good only about the current situation of Timer that becomes false when you pause it and you are able to resume it but there is no result of the timer to know actually it did finish to run other actions when it did "actually" finish.
  2. Timer has no abort/skip functionality, as a whole you may think you don't need such but actually as in my project be able to skip/abort the timer and get the finished boolean as mentioned in # 1 is crucial.
  3. Timer is no class friendly to be used in ViewModels for example. The Bindings in the initialisers are making it not work unless you import SwiftUI and make custom Binding to the Published variables.

As a request, please add extra initialisers to be able to just pass them variables in classes, abort/skip functionality and a finish report.

Thanks again for your package.

amirsaam avatar Sep 03 '24 00:09 amirsaam

@FulcrumOne sorry for the mention, but any help?

amirsaam avatar Sep 04 '24 09:09 amirsaam

Hey @amirsaam,

I'm so sorry, but unfortunately currently I can't work on it as I'm busy with three other projects:

  1. I'm updating all the libraries we have (7) to make sure they will work in the upcoming iOS
  2. I'm working on the newest library (MediaPicker) to be published
  3. I've started implementing a new model that should attract more collaborators to help us maintain our libraries

For the above reasons, the earliest I could implement the features you have asked for (which I completely agree with) is the completion of point 1 (probably around 12 September, and it will take 1-2 days to implement the new features).

Once again, I'd like to apologise for this, but I'm literally the only person who maintains all the libraries, creates new ones and has a job outside of that, so my schedule is little tight.

Let me know if the above solution works for you and have a nice day 😉, Tomasz K.

FulcrumOne avatar Sep 04 '24 09:09 FulcrumOne

@FulcrumOne Sounds awesome to me!

amirsaam avatar Sep 04 '24 09:09 amirsaam

@FulcrumOne Just wanted to ask about the timeline 😅

amirsaam avatar Sep 26 '24 12:09 amirsaam

Hey @amirsaam,

Seems that I totally miscalculated the time I needed for https://github.com/Mijick/PopupView/pull/142 😅

The work is about 50% done, but given that I also have to redesign and implement the demo project, write new documentation and do some other things related to this project, it will take at least three extra weeks to complete (super sorry for this).

Therefore, since I am the only maintainer of the seven libraries, I would suggest opting for a different solution. I'm very sorry for this, later on I will try to get someone to help me maintain the repositories.

Have a nice day, Tomasz K.

FulcrumOne avatar Sep 27 '24 18:09 FulcrumOne

@FulcrumOne Hi there, It's ok, I do understand and appreciate your work, meantime I done some hacky stuff in development to have the result I want but they're no good for production. I don't want to leave your package tbh, I wait for the changes no problem, I'm fine for now 👍

amirsaam avatar Sep 27 '24 18:09 amirsaam

@amirsaam Hey there! I want to apologize for the delay in updating this library. We have a really limited resources to work on libraries. 🥲 We've completely reworked Timer so I hope that you’ll find it much easier to control and monitor the timer's status now. The updated version can be found on the branch patch-2.0.0, and you can check out the documentation in our Wiki

alina-p-k avatar Nov 30 '24 12:11 alina-p-k

@jay-jay-lama Thanks for the effort, I do understand your situation and I appreciate what have you done but there is only one issue for me now, since I've done much custom functions in my app to use the 1.0.2 version, I'm a bit lost, can yoou please make the migration guide available? currently it is not published and gives 404 error. Thanks.

amirsaam avatar Dec 01 '24 16:12 amirsaam

@amirsaam Sure Guide will be done today in the evening.

alina-p-k avatar Dec 02 '24 09:12 alina-p-k