MLAPI.Relay icon indicating copy to clipboard operation
MLAPI.Relay copied to clipboard

Update docs and sln files

Open Budtom opened this issue 6 years ago • 2 comments

Budtom avatar Sep 24 '19 21:09 Budtom

Some questions regarding this pullrequest. Why have you included UnityEditor.dll? It's not required.

Where did you get the UnityEngine.dll from? We are not allowed to willy nilly distribute the UnityEngine dll.

Why did you include Ruffles as binary? It should be resolved via Nuget (and it is). It does not need a binary file.

TwoTenPvP avatar Sep 26 '19 17:09 TwoTenPvP

Why have you included UnityEditor.dll? It's not required. The build threw an error at runtime without the reference to the dll, with an error message asking for it's reference.

Where did you get the UnityEngine.dll from? We are not allowed to willy nilly distribute the UnityEngine dll. Sorry I did not realise that! I grabbed it from my local install

Why did you include Ruffles as binary? It should be resolved via Nuget (and it is). It does not need a binary file. Again I got a runtime error without including it and to be honest no idea why I didn't realise it was from nuget. It doesn't get included into the release folder automatically hence the < CopyLocalLockFileAssemblies csproj line

Budtom avatar Sep 26 '19 17:09 Budtom