windows-powershell-docs icon indicating copy to clipboard operation
windows-powershell-docs copied to clipboard

Update several *-FileShareAccess docs: mention that SMB share and file system security is adjusted

Open DavisNT opened this issue 2 years ago • 23 comments

PR Summary

Update:

  • Block-FileShareAccess.md
  • Grant-FileShareAccess.md
  • Revoke-FileShareAccess.md
  • Unblock-FileShareAccess.md

Mention that security descriptors of the SMB share and the underlying file system folder are adjusted by these commands. Add links to corresponding *-SmbShareAccess commands.

PR Checklist

  • [x] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • [x] Summary: This PR's summary describes the scope and intent of the change.
  • [x] Contributor's Guide: I have read the contributors guide.
  • [x] Style: This PR adheres to the style guide.

DavisNT avatar Jun 02 '23 21:06 DavisNT

Learn Build status updates of commit 4faf9c0:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2016-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@microsoft-github-policy-service agree

DavisNT avatar Jun 02 '23 21:06 DavisNT

@DavisNT

scanum avatar Jul 27 '23 04:07 scanum

Learn Build status updates of commit 3a72131:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2016-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@scanum I have rebased this PR. Is there anything else I should do?

DavisNT avatar Jul 27 '23 16:07 DavisNT

Learn Build status updates of commit aaa66da:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2016-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

Hi @tiburd hope all is well. Could you please help with this PR? Thanks!

scanum avatar Aug 06 '23 21:08 scanum

Learn Build status updates of commit 27dcce4:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2016-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/storage/Block-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Grant-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Revoke-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Unblock-FileShareAccess.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@scanum, @tiburd, @get-itips Is there anything I can help with to get this PR reviewed and merged?

DavisNT avatar Sep 17 '23 05:09 DavisNT

@get-itips Hi Andres, Please review this PR, then @ mention me after you approve. Thank you!

tiburd avatar Sep 18 '23 13:09 tiburd

@scanum, @tiburd, @get-itips Is there anything I can help with to get this PR reviewed and merged?

@DavisNT Hi Davis,

Thank you for @ mentioning us.

There is no action for you to take on this pull request at this time.

When Andres reviews this pull request, he may have changes for you to approve or make.

After he approves, I'll merge the pull request.

Thanks!

tiburd avatar Sep 18 '23 13:09 tiburd

I think @JasonGerend should be included as reviewer as it is the designated author of these articles

get-itips avatar Sep 19 '23 14:09 get-itips

I think @JasonGerend should be included as reviewer as it is the designated author of these articles

@tiburd Can you please check @get-itips's answer?

DavisNT avatar Sep 24 '23 23:09 DavisNT

@JasonGerend Is there anything I can help with to get this PR reviewed and merged?

DavisNT avatar Oct 10 '23 18:10 DavisNT

@JasonGerend Could it be possible to review these changes?

DavisNT avatar Oct 31 '23 18:10 DavisNT

@JasonGerend, @get-itips, @tiburd Could it be possible to review these changes?

DavisNT avatar Dec 05 '23 22:12 DavisNT

@JasonGerend, Could it be possible for you to do the review? CC: @get-itips, @tiburd

DavisNT avatar Mar 06 '24 23:03 DavisNT

@tiburd Looks like this is waiting for @JasonGerend's review more than 7 months already. Is there anything I can do to help?

DavisNT avatar May 01 '24 18:05 DavisNT

@tiburd, @get-itips, @JasonGerend Is there anything I can do to help this PR getting reviewed and merged?

DavisNT avatar Jul 04 '24 21:07 DavisNT

@tiburd, @get-itips, @JasonGerend Could it be possible to review this PR?

If I need to rebase it, please let me know!

DavisNT avatar Oct 19 '24 08:10 DavisNT

@get-itips, @JasonGerend, @scanum, @tiburd Can you please review this PR?

DavisNT avatar Feb 20 '25 06:02 DavisNT

@tiburd Looks like this PR has been literally stuck for years. Is there anything I can do about it? Should I rebase?

DavisNT avatar Jun 01 '25 21:06 DavisNT